[SPARK-53804][SQL] Support TIME radix sort #52520
Closed
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-toth
approved these changes
Oct 6, 2025
|
Thanks @bersprockets, merged to |
|
@peter-toth Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for radix sort of the Time type.
This PR is based on #35279, which added similar support for TimestampNTZ.
Why are the changes needed?
Better performance when sorting by one Time type column.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New test.
Also, I added temporary debug statements to
SortExecin a working copy with this change and one without this change, then tested a join by the Time type. In the working copy with the change,canUseRadixSort= true. In the working copy without the change,canUseRadixSort= false.Was this patch authored or co-authored using generative AI tooling?
No.